[
https://issues.apache.org/jira/browse/WW-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123752#comment-15123752
]
ASF GitHub Bot commented on WW-4594:
------------------------------------
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r51285002
--- Diff:
plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java ---
@@ -111,6 +133,31 @@ public void doExecute(String location,
ActionInvocation invocation) throws Excep
Request request = new ServletRequest(applicationContext,
httpRequest, httpResponse);
+ boolean definitionValid = false;
+ try {
+ LOG.debug("checking if tiles definition exists '{}'",
location);
+ definitionValid = container.isValidDefinition(location,
request);
+ } catch (TilesException e) {
+ LOG.warn("got TilesException while checking if definiton
exists, ignoring it", e);
+ }
+ if (!definitionValid) {
+ if (tilesDefinition == null) {
+ // tilesDefinition not found yet, search in action
--- End diff --
The same here, `LOG.trace`?
> Configure TilesDefs by annotating Actions
> -----------------------------------------
>
> Key: WW-4594
> URL: https://issues.apache.org/jira/browse/WW-4594
> Project: Struts 2
> Issue Type: New Feature
> Components: Plugin - Tiles
> Reporter: Christoph Nenning
> Assignee: Christoph Nenning
> Fix For: 2.5
>
>
> Large applications often consist of hundrets of actions. IMO it is a major
> benefit of struts-convention-plugin that it is not necessary to configure all
> those actions in xml files. As xml files would become huge and hard to
> maintain. The same applies to tiles xml files. Currently it is necessary to
> configure tiles-definitions for all those actions in xml files which makes
> them huge and hard to maintain.
> It would be great if configuration of tiles-definitions could be done by
> annotating actions, in a similar way actions can be configured with
> annotations from convention-plugin.
> This somewhat relates to WW-3937 and WW-4161
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
