[
https://issues.apache.org/jira/browse/WW-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058885#comment-16058885
]
Hudson commented on WW-4744:
----------------------------
SUCCESS: Integrated in Jenkins build Struts-JDK7-master #640 (See
[https://builds.apache.org/job/Struts-JDK7-master/640/])
WW-4744 WW-4694 Removes annotation search to commons lang 3.6 (yasser.zamani:
rev 33e1eeb386c98beeaeff51504a2ff156098f2c01)
* (edit)
core/src/main/java/org/apache/struts2/interceptor/validation/AnnotationValidationInterceptor.java
* (edit) core/src/main/java/org/apache/struts2/components/Component.java
* (edit)
core/src/test/java/com/opensymphony/xwork2/util/annotation/DummyClassExt.java
* (edit)
plugins/bean-validation/src/main/java/org/apache/struts/beanvalidation/validation/interceptor/BeanValidationInterceptor.java
* (edit)
core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationWorkflowInterceptor.java
* (edit)
core/src/test/java/com/opensymphony/xwork2/util/annotation/DummyClass.java
* (edit)
core/src/main/java/com/opensymphony/xwork2/interceptor/DefaultWorkflowInterceptor.java
* (edit) core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java
* (delete)
core/src/test/java/com/opensymphony/xwork2/util/annotation/MyAnnotationI.java
* (delete)
core/src/test/java/com/opensymphony/xwork2/util/annotation/DummyInterface.java
* (edit) pom.xml
* (edit)
core/src/test/java/com/opensymphony/xwork2/util/AnnotationUtilsTest.java
> AnnotationWorkflowInterceptor should supports non-public annotated methods
> --------------------------------------------------------------------------
>
> Key: WW-4744
> URL: https://issues.apache.org/jira/browse/WW-4744
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Reporter: zhouyanming
> Fix For: 2.5.next
>
>
> {code:java}
> @Before
> protected String prepare(){
> //TODO
> return null;
> }
> {code}
> [https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationWorkflowInterceptor.java#L115]
> {code:java}
> List<Method> methods = new
> ArrayList<>(AnnotationUtils.getAnnotatedMethods(action.getClass(),
> Before.class));
> {code}
> [https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java#L123]
> {code:java}
> for (Method m : clazz.getMethods())
> {code}
> clazz.getMethods() only return public methods, so method "prepare" will be
> excluded, and protected modifier is a good practice for intercept method.We
> should improve AnnotationUtils.getAnnotatedMethods() to return all methods.
> Perhaps use an ConcurrentHashMap as cache is much better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
