[
https://issues.apache.org/jira/browse/WW-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108274#comment-16108274
]
ASF GitHub Bot commented on WW-4831:
------------------------------------
GitHub user ThrawnCA opened a pull request:
https://github.com/apache/struts/pull/154
WW-4831 properly convert nulls in arrays
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ThrawnCA/struts
WW-4831-preserve-nulls-in-arrays
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit 8cc56b2974e5c744954b110e645f61f18e0b12ab
Author: thrawnca <[email protected]>
Date: 2017-08-01T01:51:20Z
[WW-4831] convert nulls within arrays to empty strings rather than the 4
letters 'null'
commit 60d61fac0abb5993977e84f8dcc5bea6588f41d6
Author: thrawnca <[email protected]>
Date: 2017-08-01T01:51:37Z
[WW-4831] add unit tests for conversion of String arrays
----
> Array-of-null parameters are converted to arrays containing "null"
> ------------------------------------------------------------------
>
> Key: WW-4831
> URL: https://issues.apache.org/jira/browse/WW-4831
> Project: Struts 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.12
> Reporter: Mitth'raw'nuruodo
> Fix For: 2.5.12
>
>
> The {{com.opensymphony.xwork2.conversion.impl.StringConverter}} class, since
> Struts 2.5.11, incorrectly handles arrays containing null; it converts them
> to arrays containing the string "null" (using {{String.valueOf}}).
> This is breaking one of our applications; some pages are OK, but on other
> pages, every non-provided field is populated with the String "null".
> This is a similar issue to WW-4737, but occurring in different code.
> Please ensure that conversion to String always uses the two-argument version
> of {{Objects.toString}}, which preserves nulls, rather than
> {{String.valueOf}}, which converts them to the four-letter string "null".
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
