[ 
https://issues.apache.org/jira/browse/WW-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113995#comment-16113995
 ] 

Mitth'raw'nuruodo edited comment on WW-4837 at 8/4/17 6:09 AM:
---------------------------------------------------------------

I know that the {{StringConverter}} class doesn't treat Integers as 
floating-point, but all our numeric-looking inputs are being turned into 
BigDecimal by the time they arrive there. I don't know which part of the Struts 
internals chooses that; we aren't declaring any parameters to be of type 
BigDecimal. Actually, I can see a bunch of affected parameters that are 
declared to be of type String in the relevant Action class, and we'd be quite 
happy for them to be just treated as String, but they're BigDecimal when 
they're passed to StringConverter. Any insights on why?


was (Author: thrawnca):
I know that the {{StringConverter}} class doesn't treat Integers as 
floating-point, but all our numeric-looking inputs are being turned into 
BigDecimal by the time they arrive there. I don't know which part of the Struts 
internals chooses that; we aren't declaring any parameters to be of type 
BigDecimal. Actually, I can see a bunch of affected parameters that are of type 
String, and we'd be quite happy for them to be just treated as String, but 
they're BigDecimal when they're passed to StringConverter..

> StringConverter adds a decimal place to integers
> ------------------------------------------------
>
>                 Key: WW-4837
>                 URL: https://issues.apache.org/jira/browse/WW-4837
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.5.12
>            Reporter: Mitth'raw'nuruodo
>             Fix For: 2.5.13
>
>
> Commit 229afea64e77c2dba9eec62b2c339e9fc92c9ec7 caused all inputs 
> recognisable as numbers to be formatted with at least one decimal place. This 
> includes all integers, which is frequently undesirable, particularly if they 
> were meant to be, eg:
> - identifiers, not for arithmetic;
> - strictly validated against an XML schema that does not allow for 
> floating-point numbers;
> - subject to length limitations;
> - etc
> This apparently occurs because all inputs that look like numbers, regardless 
> of format, are of type {{BigDecimal}} by the time they reach the 
> {{StringConverter}}.
> For our applications, this is a blocker; is it working differently for 
> others? We don't have any special handling of input types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to