[
https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157803#comment-16157803
]
Mitth'raw'nuruodo edited comment on WW-4849 at 9/7/17 10:48 PM:
----------------------------------------------------------------
"The note about default constructor in this document is very old (from 2006)."
- If it can be updated to reflect the true requirements, I'd be happy to submit
an appropriate pull request to the Guice project. Any other custom object
factories will still be broken, though.
"Unit test doesn't do whole initialization / injection cycle." - Can you
elaborate on this? What would I need to add to eg {{SpringObjectFactoryTest}}
to test this comprehensively? And when you say that the combination of
injection options "didn't play nice", what kind of failure did you observe? My
own observations were that the patched code works just fine with our
applications, presumably because they rely on the Guice object factory that
doesn't use constructor injection.
was (Author: thrawnca):
"The note about default constructor in this document is very old (from 2006)."
- If it can be updated to reflect the true requirements, I'd be happy to submit
an appropriate pull request to the Guice project. Any other custom object
factories will still be broken, though.
"Unit test doesn't do whole initialization / injection cycle." - Can you
elaborate on this? What would I need to add to eg {{SpringObjectFactoryTest}}
to test this comprehensively? And when you say that the combination of
injection options "didn't play nice", what kind of failure did you observe?
> ObjectFactory constructor signature change breaks extensions
> ------------------------------------------------------------
>
> Key: WW-4849
> URL: https://issues.apache.org/jira/browse/WW-4849
> Project: Struts 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.13
> Reporter: Mitth'raw'nuruodo
> Fix For: 2.5.14
>
>
> Commit {{6f91d0776a545c911ca4f2875ed9976614711ef9}} changed the signature of
> the {{ObjectFactory}} constructor, breaking all classes that extend
> {{ObjectFactory}} (as per https://struts.apache.org/docs/objectfactory.html).
> This affects eg the [{{guice-servlet}} Struts plugin|
> https://github.com/google/guice/blob/master/extensions/struts2/src/com/google/inject/struts2/Struts2Factory.java].
> This was not listed on the [2.5.13 version
> notes|https://struts.apache.org/docs/version-notes-2513.html] as a breaking
> change, and breaking changes should preferably be avoided in critical
> security updates.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
