davelnewton commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r416071496
##########
File path:
core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##########
@@ -192,7 +217,7 @@ protected String convertParam(String val, Map<String,
String> vars) {
c = val.charAt(x);
if (x < len - 2 &&
c == '{' && '}' == val.charAt(x+2)) {
- varVal = (String)vars.get(String.valueOf(val.charAt(x + 1)));
+ varVal = vars.get(String.valueOf(val.charAt(x + 1)));
Review comment:
(NON-BLOCKER) Never thought about it or ran in to it, but do we throw a
startup message or error if it's something *other* than 0-9 or has a spurious
`{42}` or `{42` or is that just considered part of a valid, if silly, path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
