salcho commented on pull request #428:
URL: https://github.com/apache/struts/pull/428#issuecomment-664170448


   @JCgH4164838Gh792C124B5 
   
   Hi James,
   
   Thanks so much for the follow up! We're getting ready to submit a second PR 
soon and going through your changes is very useful. We discussed whether string 
comparisons should've been case insensitive and voted against it but being 
defensive, as this PR is, really can't do any harm. 
   
   All these look good to me, in particular the fact that there's now an 
implicit empty set of exemptions in the interceptor, which I think is 
reasonable 👍 
   
   Have a great start of the week! 
   :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to