[GitHub] [struts] Yilinwang commented on pull request #458: sort results of getAnnotations() for deterministic iteration order

Sun, 13 Dec 2020 14:45:35 -0800 


Yilinwang commented on pull request #458:
URL: https://github.com/apache/struts/pull/458#issuecomment-744081458


   Thanks for replying. The flaky tests are found by the tool 
[NonDex](https://github.com/TestingResearchIllinois/NonDex) using command `mvn 
-pl plugins/json nondex:nondex` in JDK 1.8.0_272, maven 3.6.3 and here are the 
stack traces when tests failed which inspired this fix.
   
   
![image](https://user-images.githubusercontent.com/11518692/102026077-8e182080-3d61-11eb-9e87-7d24e2f75689.png)
   
![image](https://user-images.githubusercontent.com/11518692/102026041-5a3cfb00-3d61-11eb-9151-a59410900f81.png)
   
   Besides, I tested using commands `mvn -pl plugins/json test` and `mvn test` 
after the fix and they passed locally. Still trying to figure out what causes 
the Travis CI `JSONValidationInterceptorTest.testValidationFails` to fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to