JCgH4164838Gh792C124B5 commented on pull request #467: URL: https://github.com/apache/struts/pull/467#issuecomment-753679025
Hello Apache Struts Team. This is an initial attempt to add a feature to the I18N TextProvider hierarchy to read resource entries from the default bundles first, and then continue with "normal" lookup if nothing is found. It arose from a discussion on the developer list raised by G. Huber concerning the number of lookup calls when most resource entries are defined in the main application bundle. This implementation allows a developer to "opt-in" to an alternative lookup strategy where the default bundles take precedence over entries anywhere else (if an entry does not exist in the default bundles, the class hierarchy bundles are then searched normally). It should be slightly more efficient for applications that only use a "global" properties file (default resource bundle), while still providing lookups along the class hierarchy for any entries that are not defined in the default (global) resource bundles. The default value of the flag is false, which preserves the normal (original) behaviour for resource lookup (requires explicitly setting the configuration to use the alternative lookup flow). There is no JIRA yet for this item. If after reviewing this PR there is support for the change, a JIRA can be opened to cover it for tracking. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
