davoustp commented on a change in pull request #477:
URL: https://github.com/apache/struts/pull/477#discussion_r598487391



##########
File path: 
core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
##########
@@ -413,11 +411,11 @@ public ResourceBundle findResourceBundle(String 
aBundleName, Locale locale) {
                     }
                 } catch (MissingResourceException e) {
                     LOG.debug("Missing resource bundle [{}]!", aBundleName, e);
-                    missingBundles.add(key);
+                    missingBundles.put(key, Boolean.TRUE);
                 }
             } else {
                 LOG.debug("Missing resource bundle [{}]!", aBundleName);
-                missingBundles.add(key);
+                missingBundles.put(key, Boolean.TRUE);

Review comment:
       Same as above.

##########
File path: 
core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
##########
@@ -413,11 +411,11 @@ public ResourceBundle findResourceBundle(String 
aBundleName, Locale locale) {
                     }
                 } catch (MissingResourceException e) {
                     LOG.debug("Missing resource bundle [{}]!", aBundleName, e);
-                    missingBundles.add(key);
+                    missingBundles.put(key, Boolean.TRUE);

Review comment:
       Not sure that it makes any difference, but let's stick to the closest 
behaviour as mentioned.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to