[
https://issues.apache.org/jira/browse/WW-5165?focusedWorklogId=752099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752099
]
ASF GitHub Bot logged work on WW-5165:
--------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/22 05:59
Start Date: 04/Apr/22 05:59
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #533:
URL: https://github.com/apache/struts/pull/533#discussion_r841388269
##########
pom.xml:
##########
@@ -103,6 +103,20 @@
</organization>
<properties>
+ <currentVersion>${project.version}</currentVersion>
+
<struts2.springPlatformVersion>5.3.18.RELEASE</struts2.springPlatformVersion>
+ <ognl.version>3.1.8</ognl.version>
+ <asm.version>3.3</asm.version>
+ <asm5.version>5.0.2</asm5.version>
+ <tiles.version>3.0.5</tiles.version>
+ <tiles-request.version>1.0.6</tiles-request.version>
+ <log4j2.version>2.5</log4j2.version>
Review Comment:
You have duplicated these properties and some of them have been reverted to
very old versions. Also this changes nothing as the same properties are defined
a few lines below which means they will overwrite your changes - that's why all
the tests have passed.
Issue Time Tracking
-------------------
Worklog Id: (was: 752099)
Remaining Estimate: 0h (was: 10m)
Time Spent: 0.5h (was: 20m)
> Update spring to 5.3.x b/c 4.3.x is EOL
> ---------------------------------------
>
> Key: WW-5165
> URL: https://issues.apache.org/jira/browse/WW-5165
> Project: Struts 2
> Issue Type: Dependency
> Reporter: Sebastian Peters
> Priority: Major
> Fix For: 2.6
>
> Original Estimate: 0.5h
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> see
> https://spring.io/blog/2019/12/03/spring-framework-maintenance-roadmap-in-2020-including-4-3-eol
> In addition 4.3.x lists several CVEs according to
> https://mvnrepository.com/artifact/org.springframework/spring-core/4.3.30.RELEASE
> that are fixed with the newest version
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
