[ 
https://issues.apache.org/jira/browse/WW-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556560#comment-17556560
 ] 

James Chaplin commented on WW-5173:
-----------------------------------

Hi [~lukaszlenart] and [~yasserzamani] .

Thanks for the feedback and suggestions.

I attempted to remove the default constructor, but that did not seem to help 
(even after fixing the tests and calls that failed when the default constructor 
was removed).  A PR #573 was opened with some changes that at least got the 
custom factory to be returned for _container.getInstance()_ . 

Unfortunately, according to debugging, the default/bootstrap container 
construction seems to only be able to utilize the default factory instances, 
rather than the custom ones.  It behaves as if the binding is "too early" to 
allow for a custom implementation for the initial _OgnlUtil_ instances in 
default/bootstrap containers.  Maybe it requires a _ContainerProvider_ (similar 
to {_}FileManagerFactoryProvider{_}) ?  At this point I am thinking the 
relationship between the _Ognl{+}Util{+}_ and _Container_ instances are somehow 
different from a typical DI setup, but it is all guesses on my part (the DI has 
subtleties that are beyond me so far).

Any other suggestions or recommendations are welcome.  Thanks.

> Implement additional OGNL cache configuration controls
> ------------------------------------------------------
>
>                 Key: WW-5173
>                 URL: https://issues.apache.org/jira/browse/WW-5173
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 6.0.0
>            Reporter: James Chaplin
>            Priority: Minor
>
> With Struts 2.6, there may be an opportunity to introduce some additional 
> OGNL cache configuration capabilities.  One idea is to provide an cache size 
> control, and a toggle for an LRU cache mode.  These configuration controls 
> could be applied to the expression cache and BeanInfo caches independently.
> The new properties could be optional, with the framework using a standard 
> default cache if the properties are not provided.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to