JCgH4164838Gh792C124B5 commented on PR #573: URL: https://github.com/apache/struts/pull/573#issuecomment-1200522088
Hi @yasserzamani . Thank you so much for taking a look, determining what was failing, and creating PR #581 to show a working solution. 😄 I was not certain I could do a merge/rebase of your PR correctly, so I just implemented the equivalent changes in this PR (with some slight modifications). When built locally, and debugging with the sample app, the custom factory appears to get instantiated properly, so the changes you proposed/provided look like they work to me. 👍 The subtleties for how the naming/associations for the DI configuration change the behaviour are still a bit mysterious to me, but comparing what worked and did not in this PR history might be helpful to others in the future. Thank you so much, and let me know if the PR looks OK now. If anyone else would like to comment, please feel free as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
