[ https://issues.apache.org/jira/browse/WW-5241?focusedWorklogId=816948&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-816948 ]
ASF GitHub Bot logged work on WW-5241: -------------------------------------- Author: ASF GitHub Bot Created on: 14/Oct/22 10:39 Start Date: 14/Oct/22 10:39 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #611: URL: https://github.com/apache/struts/pull/611#issuecomment-1278831083 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=611) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=611&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=611&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=611&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=611&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=611&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=611&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=611&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=611&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=611&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=611&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=611&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=611&resolved=false&types=CODE_SMELL) [![68.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '68.8%')](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=611&metric=new_coverage&view=list) [68.8% Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=611&metric=new_coverage&view=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=611&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=611&metric=new_duplicated_lines_density&view=list) Issue Time Tracking ------------------- Worklog Id: (was: 816948) Time Spent: 1h (was: 50m) > <s:url includeParams="all"> is generating an invalid url when used in > conjunction with ExecuteAndWait interceptor > ----------------------------------------------------------------------------------------------------------------- > > Key: WW-5241 > URL: https://issues.apache.org/jira/browse/WW-5241 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags > Affects Versions: 6.0.3 > Reporter: Burton Rhodes > Priority: Major > Fix For: 6.1.0 > > Time Spent: 1h > Remaining Estimate: 0h > > After upgrading to v6.0.3 (from v6.0.0), the ExecuteAndWait implementation > using [this > method|https://struts.apache.org/core-developers/execute-and-wait-interceptor] > inserts "!methodName" into the to the refresh url. This results in a url > that doesn't match a struts action - resulting in a 404 error. > > A real world example is below: > Action Definition > {code:java} > <action name="LetterMergeBulk_contactList" > class="com.afs.web.struts.action.letters.LetterMergeBulkAction" > method="contactList"> > <interceptor-ref name="ExecuteAndWaitInterceptor" /> > <result > name="wait">/struts/letters/letterMergeBulkWait_popup.jsp</result> > <result>/struts/letters/letterMerge_popup.jsp</result> > </action>{code} > ExecuteAndWait (letterMergeBulkWait_popup.jsp) JSP Snippet > {code:java} > <head> > <title>Please wait</title> > <meta http-equiv="refresh" content="5;url=<s:url includeParams="all" />"/> > </head>{code} > <s:url> result in v6.0.3 - notice the inserted "!contactList" in the url > {code:java} > /afs/app/LetterMergeBulk_contactList!contactList.action?struts.token.name=token&token=A9SIKBABK17IZFM6AHSP0QSFIJHLZKJB&letterTemplateId=14773{code} > <s:url> result in v6.0.0 > {code:java} > /afs/app/LetterMergeBulk_contactList.action?struts.token.name=token&token=A9SIKBABK17IZFM6AHSP0QSFIJHLZKJB&letterTemplateId=14773{code} > > This issue was introduced in WW-5190 -- This message was sent by Atlassian Jira (v8.20.10#820010)