[ https://issues.apache.org/jira/browse/WW-4514?focusedWorklogId=823719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-823719 ]
ASF GitHub Bot logged work on WW-4514: -------------------------------------- Author: ASF GitHub Bot Created on: 06/Nov/22 08:50 Start Date: 06/Nov/22 08:50 Worklog Time Spent: 10m Work Description: lukaszlenart merged PR #630: URL: https://github.com/apache/struts/pull/630 Issue Time Tracking ------------------- Worklog Id: (was: 823719) Time Spent: 1h (was: 50m) > DefaultUrlHelper.buildParametersString appends just ? if collection is empty > ---------------------------------------------------------------------------- > > Key: WW-4514 > URL: https://issues.apache.org/jira/browse/WW-4514 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions > Affects Versions: 2.3.24 > Reporter: Jasper Rosenberg > Assignee: Lukasz Lenart > Priority: Trivial > Fix For: 6.1.0 > > Attachments: DefaultUrlHelper.patch > > Time Spent: 1h > Remaining Estimate: 0h > > DefaultUrlHelper.buildParametersString() checks that it has parameters to > append before adding the first "?"/"&", but if the only parameters are empty > Iterables/Arrays, then it shouldn't do that. > I'd suggest adding the new query string to a StringBuilder, and then if it is > non-empty, append that with the separator to the link at the end. (See patch) -- This message was sent by Atlassian Jira (v8.20.10#820010)