[ https://issues.apache.org/jira/browse/WW-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629434#comment-17629434 ]
ASF subversion and git services commented on WW-4514: ----------------------------------------------------- Commit 35a50ea836bbd56085ce8c1a4b4f13bfac113a16 in struts's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=35a50ea83 ] Merge pull request #630 from apache/WW-4514-url [WW-4514] Fixes building query string with empty parameters > DefaultUrlHelper.buildParametersString appends just ? if collection is empty > ---------------------------------------------------------------------------- > > Key: WW-4514 > URL: https://issues.apache.org/jira/browse/WW-4514 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions > Affects Versions: 2.3.24 > Reporter: Jasper Rosenberg > Assignee: Lukasz Lenart > Priority: Trivial > Fix For: 6.1.0 > > Attachments: DefaultUrlHelper.patch > > Time Spent: 1h > Remaining Estimate: 0h > > DefaultUrlHelper.buildParametersString() checks that it has parameters to > append before adding the first "?"/"&", but if the only parameters are empty > Iterables/Arrays, then it shouldn't do that. > I'd suggest adding the new query string to a StringBuilder, and then if it is > non-empty, append that with the separator to the link at the end. (See patch) -- This message was sent by Atlassian Jira (v8.20.10#820010)