[jira] [Work logged] (WW-5276) Cleanup method of request is not called

Sun, 22 Jan 2023 02:13:07 -0800 


     [ 
https://issues.apache.org/jira/browse/WW-5276?focusedWorklogId=840847&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-840847
 ]

ASF GitHub Bot logged work on WW-5276:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jan/23 10:12
            Start Date: 22/Jan/23 10:12
    Worklog Time Spent: 10m 
      Work Description: sonarcloud[bot] commented on PR #654:
URL: https://github.com/apache/struts/pull/654#issuecomment-1399446215

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=654)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=654&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=654&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=654&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=654&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=654&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=654&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=654&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=654&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=654&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=654&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=654&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=654&resolved=false&types=CODE_SMELL)
   
   
[![94.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'94.7%')](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=654&metric=new_coverage&view=list)
 [94.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=654&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=654&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=654&metric=new_duplicated_lines_density&view=list)
   
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 840847)
    Time Spent: 20m  (was: 10m)

> Cleanup method of request is not called
> ---------------------------------------
>
>                 Key: WW-5276
>                 URL: https://issues.apache.org/jira/browse/WW-5276
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 6.1.1
>            Reporter: Mirek Hankus
>            Priority: Major
>             Fix For: 6.2.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> After upgrading to 6.1.1  we have noticed that cleanup method of custom 
> MultiPartRequest is not called by struts. 
>  
>  
> It may be related to 
> [https://github.com/apache/struts/commit/69102e907551a87335231656320c8484072bdecb]
>  
> as before variable "request" was overwritten with wrapped request and cleanup 
> was called in finally section
>  
> After this commit new variable is created called "wrappedRequest", but 
> cleanup is called only on original request, and new wrappedRequest is not 
> cleaned up at all.
>  
> Below is respective code fragment
> {code:java}
> HttpServletRequest wrappedRequest = prepare.wrapRequest(request);
>                     ActionMapping mapping = 
> prepare.findActionMapping(wrappedRequest, response, true);
>                     if (mapping == null) {
>                         LOG.trace("Cannot find mapping for {}, passing to 
> other filters", uri);
>                         chain.doFilter(request, response);
>                     } else {
>                         LOG.trace("Found mapping {} for {}", mapping, uri);
>                         execute.executeAction(wrappedRequest, response, 
> mapping);
>                     }
>                 }
>             }
>         } finally {
>             prepare.cleanupRequest(request);
>         }{code}
>  
> This bug causes a lot of resource problems, and can result in denial of 
> service condition for application  (or making application not compliant - as 
> sensitive information is not properly discarded).
>  
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to