[
https://issues.apache.org/jira/browse/WW-5346?focusedWorklogId=880895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880895
]
ASF GitHub Bot logged work on WW-5346:
--------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/23 08:25
Start Date: 18/Sep/23 08:25
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #754:
URL: https://github.com/apache/struts/pull/754#discussion_r1328392319
##########
plugins/cdi/src/main/java/org/apache/struts2/cdi/CdiObjectFactory.java:
##########
@@ -173,7 +174,9 @@ protected InjectionTarget<?> getInjectionTarget(Class<?>
clazz) {
InjectionTarget<?> result;
result = injectionTargetCache.get(clazz);
if (result == null) {
- result =
beanManager.createInjectionTarget(beanManager.createAnnotatedType(clazz));
+ final InjectionTargetFactory<?> injectionTargetFactory =
Review Comment:
I noticed this file has mixed use of 4-space indents and tab indents. Let's
consolidate on 4-space indents as that is what is used in the majority of this
repo.
Issue Time Tracking
-------------------
Worklog Id: (was: 880895)
Remaining Estimate: 0h
Time Spent: 10m
> CDI Plugin: Replace deprecated BeanManager::createInjectionTarget
> ------------------------------------------------------------------
>
> Key: WW-5346
> URL: https://issues.apache.org/jira/browse/WW-5346
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - CDI
> Affects Versions: 6.3.0
> Reporter: Thomas Hepp
> Priority: Minor
> Labels: pull-request-available
> Fix For: 6.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{BeanManager::createInjectionTarget}} has been deprecated in CDI 1.1 and was
> removed in [CDI
> 4.0|https://jakarta.ee/specifications/cdi/4.0/jakarta-cdi-spec-4.0.html] ,
> making for a hard incompatability with Jakarta EE 10 (the only one in the CDI
> Plugin, all that's left is the package names).
> {{BeanManager::createInjectionTarget}} should be replaced with the
> recommended alternative {{BeanManager::getInjectionTargetFactory}} and
> {{{}InjectionTargetFactory::createInjectionTarget{}}}.
> PR on GitHub: [https://github.com/apache/struts/pull/754]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
