kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359880961
########## core/src/main/java/com/opensymphony/xwork2/ognl/DefaultOgnlCacheFactory.java: ########## @@ -15,52 +15,86 @@ */ package com.opensymphony.xwork2.ognl; -import java.util.concurrent.atomic.AtomicBoolean; -import java.util.concurrent.atomic.AtomicInteger; import org.apache.commons.lang3.BooleanUtils; /** - * Default OGNL Cache factory implementation. + * <p>Default OGNL Cache factory implementation.</p> * - * Currently used for Expression cache and BeanInfo cache creation. + * <p>Currently used for Expression cache and BeanInfo cache creation.</p> * - * @param <Key> The type for the cache key entries + * @param <Key> The type for the cache key entries * @param <Value> The type for the cache value entries */ public class DefaultOgnlCacheFactory<Key, Value> implements OgnlCacheFactory<Key, Value> { - private final AtomicBoolean useLRUCache = new AtomicBoolean(false); - private final AtomicInteger cacheMaxSize = new AtomicInteger(25000); Review Comment: Making this factory class thread-safe seemed unnecessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org