sepe81 commented on code in PR #773:
URL: https://github.com/apache/struts/pull/773#discussion_r1368740508
##########
core/src/main/java/org/apache/struts2/url/StrutsUrlDecoder.java:
##########
@@ -107,7 +110,7 @@ private byte convertHexDigit(byte b) {
}
private Charset getCharset(String encoding) throws
UnsupportedEncodingException {
- for (Charset charset : Charset.availableCharsets().values()) {
+ for (Charset charset : AVAILAVLE_CHARSETS) {
Review Comment:
```suggestion
for (Charset charset : AVAILABLE_CHARSETS) {
```
##########
core/src/main/java/org/apache/struts2/url/StrutsUrlDecoder.java:
##########
@@ -27,11 +27,14 @@
import java.io.UnsupportedEncodingException;
import java.nio.charset.Charset;
+import java.util.Collection;
public class StrutsUrlDecoder implements UrlDecoder {
private static final Logger LOG =
LogManager.getLogger(StrutsUrlDecoder.class);
+ private static final Collection<Charset> AVAILAVLE_CHARSETS =
Charset.availableCharsets().values();
Review Comment:
```suggestion
private static final Collection<Charset> AVAILABLE_CHARSETS =
Charset.availableCharsets().values();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
