[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=888918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-888918 ]
ASF GitHub Bot logged work on WW-5333: -------------------------------------- Author: ASF GitHub Bot Created on: 06/Nov/23 07:27 Start Date: 06/Nov/23 07:27 Worklog Time Spent: 10m Work Description: lukaszlenart commented on code in PR #779: URL: https://github.com/apache/struts/pull/779#discussion_r1382869354 ########## core/src/main/java/org/apache/struts2/dispatcher/DispatcherScope.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.struts2.dispatcher; + +public interface DispatcherScope { Review Comment: I started with enum but then I noticed this is used as string only, let me re-think this approach Issue Time Tracking ------------------- Worklog Id: (was: 888918) Time Spent: 50m (was: 40m) > Refactor AttributeMap > --------------------- > > Key: WW-5333 > URL: https://issues.apache.org/jira/browse/WW-5333 > Project: Struts 2 > Issue Type: Improvement > Components: Core > Reporter: Lukasz Lenart > Priority: Minor > Fix For: 6.4.0 > > Time Spent: 50m > Remaining Estimate: 0h > > {{AttributeMap}} is still using raw {{Map}} instead of being more generic. > Also instead of basing on raw Map an instance of {{ActionContext}} should be > used. -- This message was sent by Atlassian Jira (v8.20.10#820010)