[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895024
]
ASF GitHub Bot logged work on WW-5141:
--------------------------------------
Author: ASF GitHub Bot
Created on: 11/Dec/23 14:21
Start Date: 11/Dec/23 14:21
Worklog Time Spent: 10m
Work Description: jdyer1 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1422533854
##########
core/src/test/java/org/apache/struts2/views/jsp/BeanTagTest.java:
##########
@@ -51,8 +51,8 @@ public void testSimple() {
fail();
}
- request.verify();
- pageContext.verify();
Review Comment:
@yasserzamani Thank you for your review. I can say for sure that
"pageContext.verify()" is a no-op. As for the request, my belief is the mock
is designed to let the tester set up a series of expectations, then call
"verify" when the test is ready to check them. However, this test seems to set
no expectations, so my belief is the "verify" method here also would do nothing.
You touch here on what I consider to be the most risky of these changes:
The "mockobjects" library for the servlet api could no longer be used so I
replaced them with the Spring library's mocks. However, the Spring mocks do
not support this "set/verify" pattern so in the few places our code uses it, I
had to make a judgement as to what I thought the original intent was. I cannot
say for sure I got this right 100% of the time!
Issue Time Tracking
-------------------
Worklog Id: (was: 895024)
Time Spent: 7h (was: 6h 50m)
> Support for JEE 9+
> -------------------
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
> Reporter: Daniel Le Berre
> Priority: Major
> Labels: M1
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
