[
https://issues.apache.org/jira/browse/WW-5362?focusedWorklogId=896066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-896066
]
ASF GitHub Bot logged work on WW-5362:
--------------------------------------
Author: ASF GitHub Bot
Created on: 18/Dec/23 12:55
Start Date: 18/Dec/23 12:55
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #812:
URL: https://github.com/apache/struts/pull/812#discussion_r1430111114
##########
assembly/src/main/resources/template.vm:
##########
@@ -43,12 +43,12 @@ under the License.
<script src='http://struts.apache.org/highlighter/js/$hscript'
type='text/javascript'></script>
#end
- <script type="text/javascript">
+ <script>
SyntaxHighlighter.defaults['toolbar'] = false;
SyntaxHighlighter.all();
</script>
#end
- <script type="text/javascript" language="javascript">
+ <script language="javascript">
Review Comment:
```suggestion
<script>
```
Should the language attribute also be removed?
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#deprecated_attributes
states:
>Like the type attribute, this attribute identifies the scripting language
in use. Unlike the type attribute, however, this attribute's possible values
were never standardized. The type attribute should be used instead.
Issue Time Tracking
-------------------
Worklog Id: (was: 896066)
Time Spent: 1h 50m (was: 1h 40m)
> Remove type attribute out of <s:script/> tag
> --------------------------------------------
>
> Key: WW-5362
> URL: https://issues.apache.org/jira/browse/WW-5362
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Tags
> Reporter: Lukasz Lenart
> Priority: Minor
> Fix For: 6.4.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The {{type}} attribute should not be set if refers to a default value to
> avoid warnings
> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script/type
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
