[
https://issues.apache.org/jira/browse/WW-5379?focusedWorklogId=897628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897628
]
ASF GitHub Bot logged work on WW-5379:
--------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jan/24 09:45
Start Date: 02/Jan/24 09:45
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #822:
URL: https://github.com/apache/struts/pull/822#discussion_r1439286738
##########
plugins/velocity/src/main/java/org/apache/struts2/views/velocity/StrutsVelocityContext.java:
##########
@@ -96,11 +96,15 @@ protected Object chainedContextGet(String key) {
return null;
}
for (VelocityContext chainedContext : chainedContexts) {
- Object val = chainedContext.internalGet(key);
+ Object val = chainedContext.get(key);
if (val != null) {
return val;
}
}
return null;
}
+
+ public ValueStack getValueStack() {
+ return stack;
+ }
Review Comment:
Do we need to have this public? Also this requires to cast to
`StrutsVelocityContext`, wouldn't be better to have a marking interface
`ValueStackAware` or `ValueStackProvider` to expose the ValueStack?
Issue Time Tracking
-------------------
Worklog Id: (was: 897628)
Time Spent: 1h 20m (was: 1h 10m)
> Implement alternative mechanism for Velocity directives to obtain stack
> -----------------------------------------------------------------------
>
> Key: WW-5379
> URL: https://issues.apache.org/jira/browse/WW-5379
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Velocity
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.4.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
