[
https://issues.apache.org/jira/browse/WW-5382?focusedWorklogId=898143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898143
]
ASF GitHub Bot logged work on WW-5382:
--------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jan/24 06:32
Start Date: 05/Jan/24 06:32
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #826:
URL: https://github.com/apache/struts/pull/826#discussion_r1442533126
##########
core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java:
##########
@@ -192,6 +194,11 @@ public class Dispatcher {
* Store ConfigurationManager instance, set on init.
*/
protected ConfigurationManager configurationManager;
+ private ObjectFactory objectFactory;
Review Comment:
Maybe they should be moved into constructor?
##########
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java:
##########
@@ -325,12 +325,8 @@ public Class<? extends Configuration> type() {
}
protected ActionContext setContext(Container cont) {
- ActionContext context = ActionContext.getContext();
- if (context == null) {
Review Comment:
To be honest I would love to re-organise the whole proces. I assume the
`ActionContext` is only needed when serving an action, it should be created
just before and destroyed just after.
##########
core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java:
##########
@@ -988,18 +1031,7 @@ protected boolean isMultipartRequest(HttpServletRequest
request) {
* @return a multi part request object
*/
protected MultiPartRequest getMultiPartRequest() {
- MultiPartRequest mpr = null;
- //check for alternate implementations of MultiPartRequest
- Set<String> multiNames =
getContainer().getInstanceNames(MultiPartRequest.class);
- for (String multiName : multiNames) {
- if (multiName.equals(multipartHandlerName)) {
- mpr = getContainer().getInstance(MultiPartRequest.class,
multiName);
- }
- }
- if (mpr == null) {
- mpr = getContainer().getInstance(MultiPartRequest.class);
- }
- return mpr;
+ return getContainer().getInstance(MultiPartRequest.class);
Review Comment:
Shouldn't it be an instance field as other?
##########
core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java:
##########
@@ -988,18 +1031,7 @@ protected boolean isMultipartRequest(HttpServletRequest
request) {
* @return a multi part request object
*/
protected MultiPartRequest getMultiPartRequest() {
- MultiPartRequest mpr = null;
Review Comment:
Hm... good question, no idea :)
Issue Time Tracking
-------------------
Worklog Id: (was: 898143)
Time Spent: 1h 40m (was: 1.5h)
> Stale configuration persists after configuration reload
> -------------------------------------------------------
>
> Key: WW-5382
> URL: https://issues.apache.org/jira/browse/WW-5382
> Project: Struts 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 6.3.0
> Reporter: Kusal Kithul-Godage
> Priority: Major
> Fix For: 6.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
