[jira] [Work logged] (WW-5360) Struts 2 and JDK 17 numbers in locale

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-5360?focusedWorklogId=900831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900831
 ]

ASF GitHub Bot logged work on WW-5360:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jan/24 17:09
            Start Date: 21/Jan/24 17:09
    Worklog Time Spent: 10m 
      Work Description: sonarcloud[bot] commented on PR #852:
URL: https://github.com/apache/struts/pull/852#issuecomment-1902698258

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=852) 
**Quality Gate failed**  
   Failed conditions
   
   [10 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=852&resolved=false&inNewCodePeriod=true)
  
   [28.5% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=852&metric=new_coverage&view=list)
 (required ≥ 80%)  
   [4.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=852&metric=new_duplicated_lines_density&view=list)
 (required ≤ 3%)  
   [E Reliability Rating on New 
Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=852) 
(required ≥ A)  
   [E Security Rating on New 
Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=852) 
(required ≥ A)  
     
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=852)
   
   
   
   
![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 'idea') Catch issues before they fail your Quality Gate with our IDE extension 
![SonarLint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 'SonarLint') 
[SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)




Issue Time Tracking
-------------------

    Worklog Id:     (was: 900831)
    Time Spent: 0.5h  (was: 20m)

> Struts 2 and JDK 17 numbers in locale
> -------------------------------------
>
>                 Key: WW-5360
>                 URL: https://issues.apache.org/jira/browse/WW-5360
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 6.3.0
>            Reporter: Alireza Fattahi
>            Priority: Major
>             Fix For: 6.4.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> With struts `6.3.0.1` and jdk 8 in locale `fa_IR` the below generates `1, 2, 
> 3,`
>  
> {code:java}
>          <s:iterator begin="1" end="3">
>                     <s:property value="top"/>,
>          </s:iterator>{code}
>  
> By upgrading to jdk 17 It generates `۱, ۲, ۳,` ( these are Persian numbers 
> for `1, 2, 3,`)  
>  
> I have asked it at 
> [https://stackoverflow.com/questions/77250075/struts-2-and-jdk-17-numbers-in-locale]
>  and got a workaround by Roman C.
>  
> How ever I think this is something that could be fixed. Developers most of 
> the times, use `s:iterator` to generate numbers which will be used in their 
> code, not to show them to user. 
> So for example a loop which generates 10 inputboxs with names as `inputbox_1, 
> inputbox-2 ... `  will now generate `inputbox_۱, inputbox-۲ ... `.. lots of 
> things need to be changed. ( The JavaScript which you developed base on 
> English number, the name of the variables which was set in action ...)
> I suggest that the `s:iterator` always generates English number, or at list 
> has a property that can be configured. Or even we can configure this behavior 
> globally with an `struts.xml`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)