[
https://issues.apache.org/jira/browse/WW-5388?focusedWorklogId=901362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901362
]
ASF GitHub Bot logged work on WW-5388:
--------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/24 08:27
Start Date: 24/Jan/24 08:27
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #861:
URL: https://github.com/apache/struts/pull/861#discussion_r1464504379
##########
core/src/main/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequest.java:
##########
@@ -171,4 +171,8 @@ protected String getCanonicalName(final String
originalFileName) {
return fileName;
}
+ protected String sanitizeNewlines(String before) {
+ return before.replaceAll("[\n\r]", "_");
Review Comment:
```suggestion
return before.replaceAll("\R", "_");
```
maybe use this as more concise way to represent line breaks?
>Any Unicode linebreak sequence, is equivalent to
\u000D\u000A|[\u000A\u000B\u000C\u000D\u0085\u2028\u2029]
Issue Time Tracking
-------------------
Worklog Id: (was: 901362)
Time Spent: 20m (was: 10m)
> Upgrade Commons Fileupload to FileUpload Jakarta Servlet 6
> ----------------------------------------------------------
>
> Key: WW-5388
> URL: https://issues.apache.org/jira/browse/WW-5388
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 7.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There is a new version of JakartaEE FileUpload
> {code:xml}
> <dependency>
> <groupId>org.apache.commons</groupId>
> <artifactId>commons-fileupload2-jakarta-servlet6</artifactId>
> <version>2.0.0-M2</version>
> </dependency>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
