[
https://issues.apache.org/jira/browse/WW-5251?focusedWorklogId=912085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912085
]
ASF GitHub Bot logged work on WW-5251:
--------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/24 16:49
Start Date: 28/Mar/24 16:49
Worklog Time Spent: 10m
Work Description: brianandle commented on code in PR #898:
URL: https://github.com/apache/struts/pull/898#discussion_r1543300844
##########
core/src/main/java/org/apache/struts2/interceptor/ParameterAware.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.struts2.interceptor;
+
+import org.apache.struts2.dispatcher.HttpParameters;
+
+import java.util.Map;
+
+@Deprecated
+public interface ParameterAware extends
org.apache.struts2.action.ParametersAware {
+
+ void setParameters(Map map);
+
+ @Override
+ default void withParameters(HttpParameters parameters) {
+ setParameters(parameters);
Review Comment:
That makes sense to not revert all of the ActionContext change. It might
make sense to add back getName(), since it was never marked deprecated, marking
deprecated and removing in 7.0.0.
I agree that reverting something that would re-expose a security issue
wouldn't make sense. If the revert in https://github.com/apache/struts/pull/897
was done for 6.4.0.0 then from our implementation we'd be good to go. I created
WW-5403 thinking about the community at large and that it could cause adoption
issues.
Issue Time Tracking
-------------------
Worklog Id: (was: 912085)
Time Spent: 3h 10m (was: 3h)
> Remove deprecated interfaces used with ServletConfigInterceptor
> ---------------------------------------------------------------
>
> Key: WW-5251
> URL: https://issues.apache.org/jira/browse/WW-5251
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 7.0.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> {{ServletConfigInterceptor}} supports a bunch of deprecated interfaces which
> already have proper replacement and they should be removed
> * {{org.apache.struts2.util.ServletContextAware}}
> * {{org.apache.struts2.interceptor.ServletRequestAware}}
> * {{org.apache.struts2.interceptor.ServletResponseAware}}
> * {{org.apache.struts2.interceptor.ParameterAware}}
> * {{org.apache.struts2.interceptor.SessionAware}}
> * {{org.apache.struts2.interceptor.ApplicationAware}}
> * {{org.apache.struts2.interceptor.PrincipalAware}}
> all these interfaces have proper replacement in {{org.apache.struts2.action}}
> package
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
