[
https://issues.apache.org/jira/browse/WW-5419?focusedWorklogId=915740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915740
]
ASF GitHub Bot logged work on WW-5419:
--------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/24 04:50
Start Date: 22/Apr/24 04:50
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #920:
URL: https://github.com/apache/struts/pull/920#discussion_r1574120929
##########
plugins/tiles/src/main/java/org/apache/struts2/tiles/StrutsTilesContainerFactory.java:
##########
@@ -105,19 +102,8 @@ public class StrutsTilesContainerFactory extends
BasicTilesContainerFactory {
/**
* Default pattern to be used to collect Tiles definitions if user didn't
configure any
- *
- * @deprecated since Struts 6.4.0, use {@link #TILES_DEFAULT_PATTERNS}
instead
*/
- @Deprecated
- public static final String TILES_DEFAULT_PATTERN =
"/WEB-INF/**/tiles*.xml,classpath*:META-INF/**/tiles*.xml";
-
- /**
- * Default pattern to be used to collect Tiles definitions if user didn't
configure any
- */
- public static final Set<String> TILES_DEFAULT_PATTERNS =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
Review Comment:
Right, fixed
Issue Time Tracking
-------------------
Worklog Id: (was: 915740)
Time Spent: 1h 10m (was: 1h)
> Autoloading of tiles.xml fails in Struts-6.4.0
> ----------------------------------------------
>
> Key: WW-5419
> URL: https://issues.apache.org/jira/browse/WW-5419
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Tiles
> Affects Versions: 6.4.0
> Reporter: Markus Fischer
> Assignee: Lukasz Lenart
> Priority: Blocker
> Fix For: 6.5.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Starting in 6.4.0 a tiles definition in {{/WEB-INF/tiles.xml}} is not found
> automatically anymore. The problem arises only, if the definition in web.xml
> contains no param section:
> {code:xml}
> <listener>
>
> <listener-class>org.apache.struts2.tiles.StrutsTilesListener</listener-class>
> </listener>
> {code}
>
> The workaround is to specify the specific location:
> {code:xml}
> <listener>
>
> <listener-class>org.apache.struts2.tiles.StrutsTilesListener</listener-class>
> </listener>
> <context-param>
>
> <param-name>org.apache.tiles.definition.DefinitionsFactory.DEFINITIONS_CONFIG</param-name>
> <param-value>
> /WEB-INF/tiles.xml
> </param-value>
> </context-param>
> {code}
>
> The issue has been introduced by this
> [change|https://github.com/apache/struts/pull/896/commits/c7ae614824b4c158b9998575294d94fe9a746c41]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
