[
https://issues.apache.org/jira/browse/WW-5428?focusedWorklogId=924750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-924750
]
ASF GitHub Bot logged work on WW-5428:
--------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/24 06:54
Start Date: 08/Jul/24 06:54
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #967:
URL: https://github.com/apache/struts/pull/967#discussion_r1668086483
##########
core/src/test/java/com/opensymphony/xwork2/ognl/SecurityMemberAccessTest.java:
##########
@@ -931,6 +981,15 @@ public void packageInclusion_subclass_both() throws
Exception {
private static String formGetterName(String propertyName) {
return "get" + propertyName.substring(0, 1).toUpperCase() +
propertyName.substring(1);
}
+
+ @SuppressWarnings("unchecked")
+ private static <T> T mockHibernateProxy(T originalObject, Class<T>
proxyInterface) {
Review Comment:
Mocking a Hibernate proxy isn't perfect - integration/acceptance tests would
offer better protection against regressions but I'd prefer not to complicate
the tests further by introducing a Hibernate session factory etc
Issue Time Tracking
-------------------
Worklog Id: (was: 924750)
Time Spent: 50m (was: 40m)
> Allowlist capability should resolve Hibernate proxies when
> disableProxyObjects is not set
> -----------------------------------------------------------------------------------------
>
> Key: WW-5428
> URL: https://issues.apache.org/jira/browse/WW-5428
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.5.0, 7.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Refer to PR description for further details
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
