[
https://issues.apache.org/jira/browse/WW-5439?focusedWorklogId=924765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-924765
]
ASF GitHub Bot logged work on WW-5439:
--------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/24 09:19
Start Date: 08/Jul/24 09:19
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #979:
URL: https://github.com/apache/struts/pull/979#discussion_r1668291315
##########
core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java:
##########
@@ -1284,12 +1295,11 @@ public void testAvoidCallingMethodsWithBraces() {
assertEquals(expected.getMessage(), "Inappropriate OGNL expression:
toString()");
}
- public void testAvoidCallingSomeClasses() {
+ public void testStaticMethodBlocked() {
Foo foo = new Foo();
Exception expected = null;
try {
- ognlUtil.setExcludedClasses(Runtime.class.getName());
Review Comment:
The exclusion list isn't checked here as it's already blocked by the static
method check
##########
core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java:
##########
@@ -1166,9 +1171,11 @@ public void testAvoidCallingMethodsOnObjectClass() {
public void testAllowCallingMethodsOnObjectClassInDevModeTrue() {
Exception expected = null;
try {
- ognlUtil.setExcludedClasses(Foo.class.getName());
Review Comment:
These methods don't do anything, so we inject the configuration instead
Issue Time Tracking
-------------------
Worklog Id: (was: 924765)
Time Spent: 0.5h (was: 20m)
> Fix and clean up devMode excluded classes
> -----------------------------------------
>
> Key: WW-5439
> URL: https://issues.apache.org/jira/browse/WW-5439
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.5.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
