[
https://issues.apache.org/jira/browse/WW-5440?focusedWorklogId=925810&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925810
]
ASF GitHub Bot logged work on WW-5440:
--------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jul/24 06:50
Start Date: 14/Jul/24 06:50
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #986:
URL: https://github.com/apache/struts/pull/986#discussion_r1677041654
##########
core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Allowed.java:
##########
@@ -28,9 +28,11 @@
* a HttpRequest parameter.
*
* @author martin.gilday
+ * @deprecated since 6.6.0, use {@link
org.apache.struts2.interceptor.parameter.StrutsParameter}.
Review Comment:
❤️
##########
core/src/test/java/org/apache/struts2/ExecutionCountTestAction.java:
##########
@@ -41,9 +41,10 @@ public int getExecutionCount() {
return executionCount;
}
+ @Override
public String execute() throws Exception {
executionCount++;
- LOG.info("executing ExecutionCountTestAction. Current count is " +
executionCount);
+ LOG.info("executing ExecutionCountTestAction. Current count is {}",
executionCount);
Review Comment:
❤️
##########
plugins/config-browser/src/main/java/org/apache/struts2/config_browser/ShowConfigAction.java:
##########
@@ -98,16 +104,17 @@ public PropertyDescriptor[] getProperties() {
return properties;
}
+ @Override
public String execute() throws Exception {
super.execute();
config = configHelper.getActionConfig(namespace, actionName);
- actionNames = new
TreeSet<String>(configHelper.getActionNames(namespace));
+ actionNames = new TreeSet<>(configHelper.getActionNames(namespace));
try {
Object action = objectFactory.buildAction(actionName, namespace,
config, null);
properties = reflectionProvider.getPropertyDescriptors(action);
} catch (Exception e) {
- LOG.error("Unable to get properties for action " + actionName, e);
- addActionError("Unable to retrieve action properties: " +
e.toString());
+ LOG.error("Unable to get properties for action {}", actionName, e);
Review Comment:
This won't work, you must use `ParameterizedMessage` like this
```java
LOG.error(new ParameterizedMessage("Unable to get properties for action {}",
actionName), e);
```
##########
core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationParameterFilterInterceptor.java:
##########
@@ -46,7 +46,10 @@
* </p>
*
* @author martin.gilday
+ * @deprecated since 6.6.0, integrated into {@link ParametersInterceptor} with
{@link StrutsParameter} using
Review Comment:
Do we have a task to remove this interceptor in Struts 7?
Issue Time Tracking
-------------------
Worklog Id: (was: 925810)
Time Spent: 50m (was: 40m)
> Fix OGNL allowlist compatibility with Convention plugin
> -------------------------------------------------------
>
> Key: WW-5440
> URL: https://issues.apache.org/jira/browse/WW-5440
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
> Affects Versions: 6.4.0
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.6.0, 7.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
