[ 
https://issues.apache.org/jira/browse/WW-5514?focusedWorklogId=1004134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1004134
 ]

ASF GitHub Bot logged work on WW-5514:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Feb/26 08:57
            Start Date: 09/Feb/26 08:57
    Worklog Time Spent: 10m 
      Work Description: lukaszlenart opened a new pull request, #1572:
URL: https://github.com/apache/struts/pull/1572

   ## Summary
   
   Introduces a configurable `ProxyService` interface and `StrutsProxyService` 
implementation for detecting and resolving Spring AOP/Hibernate proxies.
   
   Fixes [WW-5514](https://issues.apache.org/jira/browse/WW-5514)
   
   ### Key Changes
   
   - **ProxyService interface** with `isProxy`, `ultimateTargetClass`, and 
`resolveTargetMember` methods
   - **StrutsProxyService** implementation using configurable caches
   - **ProxyCacheFactory** and **StrutsProxyCacheFactory** for cache management
   - Integration into `ChainingInterceptor`, `ParametersInterceptor`, and 
`SecurityMemberAccess`
   - **Integration test** with Spring AOP proxied action chaining
   - Configuration constants for proxy cache type and size
   
   ### Proxy Types Supported
   
   - Spring CGLIB proxies (class-based)
   - Spring JDK dynamic proxies (interface-based)  
   - Hibernate entity proxies
   - Member resolution for allowlist checking
   
   ### Configuration
   
   New properties in `default.properties`:
   ```properties
   struts.proxy.cacheType=basic
   struts.proxy.cacheMaxSize=10000
   struts.proxy.cacheFactory=struts
   struts.proxyService=struts
   ```
   
   ### Test Plan
   
   - [x] Unit tests for `StrutsProxyService`
   - [x] Unit tests for `StrutsProxyCacheFactory`
   - [x] Unit tests for `SecurityMemberAccessProxyTest`
   - [x] Integration test `SpringProxyActionChainingTest`
   - [ ] Manual testing with Spring AOP proxied actions
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)




Issue Time Tracking
-------------------

            Worklog Id:     (was: 1004134)
    Remaining Estimate: 0h
            Time Spent: 10m

> Allow configuration of ProxyUtil for cache types
> ------------------------------------------------
>
>                 Key: WW-5514
>                 URL: https://issues.apache.org/jira/browse/WW-5514
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 6.6.0
>            Reporter: Jon Pulice
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 6.9.0, 7.2.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Since 6.6.0, the ProxyUtil class now always uses the WTLFU cache type when 
> creating its two internal caches. This means that the caffeine 
> library is now mandatory when it was not before.
> {code:java}
>   private static final OgnlCache<Class<?>, Boolean> isProxyCache = (new 
> DefaultOgnlCacheFactory(10000, OgnlCacheFactory.CacheType.WTLFU, 256))
>     .buildOgnlCache();
>   private static final OgnlCache<Member, Boolean> isProxyMemberCache = (new 
> DefaultOgnlCacheFactory(10000, OgnlCacheFactory.CacheType.WTLFU, 256))
>     .buildOgnlCache();{code}
>  
> Prior to 6.6.0, setting both of these configuration options would allow you 
> to omit the caffeine dependency from an application:
> {code:java}
> <constant name="struts.ognl.expressionCacheType" value ="basic" />
> <constant name="struts.ognl.beanInfoCacheType" value="basic" />{code}
>  
> Would it be possible to allow for the cache type used by the ProxyUtil class 
> to be configurable as well similar to the above?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to