[
https://issues.apache.org/jira/browse/WW-5514?focusedWorklogId=1006482&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1006482
]
ASF GitHub Bot logged work on WW-5514:
--------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/26 15:52
Start Date: 21/Feb/26 15:52
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #1573:
URL: https://github.com/apache/struts/pull/1573#discussion_r2836302409
##########
core/src/main/java/com/opensymphony/xwork2/util/LazyRef.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.opensymphony.xwork2.util;
+
+import java.util.function.Supplier;
+
+/**
+ * A thread-safe lazy reference that computes its value on first access using
+ * double-checked locking. The cached value can be invalidated via {@link
#reset()},
+ * causing the next {@link #get()} call to recompute the value.
+ *
+ * @param <T> the type of the lazily computed value
+ * @since 6.9.0
+ */
+public class LazyRef<T> implements Supplier<T> {
+
+ private final Supplier<T> factory;
+ private volatile T value;
+
+ /**
+ * Creates a new LazyRef with the given factory supplier.
+ *
+ * @param factory the supplier used to compute the value; must not be null
+ */
+ public LazyRef(Supplier<T> factory) {
+ this.factory = factory;
+ }
+
+ /**
+ * Returns the cached value, computing it on first access or after a
{@link #reset()}.
+ *
+ * @return the computed value
+ */
+ @Override
+ public T get() {
+ T result = value;
+ if (result == null) {
+ synchronized (this) {
+ result = value;
+ if (result == null) {
+ result = factory.get();
+ value = result;
+ }
+ }
+ }
+ return result;
+ }
+
+ /**
+ * Invalidates the cached value so the next {@link #get()} call recomputes
it.
+ */
+ public void reset() {
Review Comment:
Should technically be `synchronized` but anyway it's a super edge case so I
wouldn't worry
Issue Time Tracking
-------------------
Worklog Id: (was: 1006482)
Time Spent: 3h 20m (was: 3h 10m)
> Allow configuration of ProxyUtil for cache types
> ------------------------------------------------
>
> Key: WW-5514
> URL: https://issues.apache.org/jira/browse/WW-5514
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 6.6.0
> Reporter: Jon Pulice
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 6.9.0, 7.2.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Since 6.6.0, the ProxyUtil class now always uses the WTLFU cache type when
> creating its two internal caches. This means that the caffeine
> library is now mandatory when it was not before.
> {code:java}
> private static final OgnlCache<Class<?>, Boolean> isProxyCache = (new
> DefaultOgnlCacheFactory(10000, OgnlCacheFactory.CacheType.WTLFU, 256))
> .buildOgnlCache();
> private static final OgnlCache<Member, Boolean> isProxyMemberCache = (new
> DefaultOgnlCacheFactory(10000, OgnlCacheFactory.CacheType.WTLFU, 256))
> .buildOgnlCache();{code}
>
> Prior to 6.6.0, setting both of these configuration options would allow you
> to omit the caffeine dependency from an application:
> {code:java}
> <constant name="struts.ognl.expressionCacheType" value ="basic" />
> <constant name="struts.ognl.beanInfoCacheType" value="basic" />{code}
>
> Would it be possible to allow for the cache type used by the ProxyUtil class
> to be configurable as well similar to the above?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
