[ 
https://issues.apache.org/jira/browse/WW-5621?focusedWorklogId=1012026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1012026
 ]

ASF GitHub Bot logged work on WW-5621:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Mar/26 06:16
            Start Date: 29/Mar/26 06:16
    Worklog Time Spent: 10m 
      Work Description: lukaszlenart opened a new pull request, #1643:
URL: https://github.com/apache/struts/pull/1643

   ## Summary
   
   Backport of #1642 from Struts 7 to Struts 6.
   
   - Enable `FEATURE_SECURE_PROCESSING` in `DomHelper` and Tiles 
`DigesterDefinitionsReader`
   - Remove unused `parseStringAsXML` feature from `StringAdapter` to eliminate 
theoretical attack surface
   - Deprecate `getParseStringAsXML()` / `setParseStringAsXML()` for future 
removal
   - Add Billion Laughs protection tests for both XML parsers
   
   ## Test plan
   
   - [x] `mvn test -DskipAssembly -pl core -Dtest=DomHelperTest` — 4 tests pass
   - [x] `mvn test -DskipAssembly -pl plugins/tiles 
-Dtest="TestDigesterDefinitionsReader#testBillionLaughsProtection"` — 1 test 
passes
   - [x] `mvn test -DskipAssembly -pl plugins/xslt` — builds successfully
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)




Issue Time Tracking
-------------------

    Worklog Id:     (was: 1012026)
    Time Spent: 50m  (was: 40m)

> Harden XML parsers against Entity Expansion (Billion Laughs) attacks
> --------------------------------------------------------------------
>
>                 Key: WW-5621
>                 URL: https://issues.apache.org/jira/browse/WW-5621
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - XSLT
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 6.9.0, 7.2.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Defense-in-depth hardening of XML parsers. Modern JDKs (7u45+) already 
> enforce a 64K entity expansion limit, so this is not an exploitable 
> vulnerability — all XML sources come from the classpath, not user input.
> Changes:
>   - Remove unused {{parseStringAsXML}} feature from {{StringAdapter}} to 
> eliminate theoretical attack surface
>   - Deprecate {{getParseStringAsXML()}} / {{setParseStringAsXML()}} for 
> future removal
>   - Enable {{FEATURE_SECURE_PROCESSING}} in Tiles 
> {{DigesterDefinitionsReader}}
>   - Add unit test verifying JDK entity expansion limit rejects Billion Laughs 
> payloads



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to