[
https://issues.apache.org/jira/browse/WW-5645?focusedWorklogId=1029691&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1029691
]
ASF GitHub Bot logged work on WW-5645:
--------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/26 19:12
Start Date: 12/Jul/26 19:12
Worklog Time Spent: 10m
Work Description: arunmanni-ai commented on PR #1777:
URL: https://github.com/apache/struts/pull/1777#issuecomment-4952417268
I replaced the denylist with a canonicalise-then-verify approach.
containsMalformedPathSegment is now canonicalisePath, which normalises the path
(resolves . and .., converts \ to /) and returns Optional.empty() if it escapes
above root. Both findStaticResource and the WebJar split() now use the
canonical form for downstream lookups. Dropped the %2e denylist and its test,
and removed the now-dead setEncoding call from the test setUp.
All four points addressed
Issue Time Tracking
-------------------
Worklog Id: (was: 1029691)
Time Spent: 50m (was: 40m)
> Remove redundant URL decode and harden path handling in static content serving
> ------------------------------------------------------------------------------
>
> Key: WW-5645
> URL: https://issues.apache.org/jira/browse/WW-5645
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 7.2.1
> Reporter: Arun Manni
> Priority: Minor
> Fix For: 7.3.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> buildPath() in DefaultStaticContentLoader applies URLDecoder.decode() to
> resource paths that the servlet container has already decoded. This
> redundant decode serves no purpose and conflicts with the servlet spec's
> path handling contract.
> This patch removes the unnecessary decode, adds a shared
> Validator.containsMalformedPathSegment() utility that rejects malformed
> path segments (dot-dot sequences, backslash separators, and
> percent-encoded forms), applies it in both the static content and WebJar
> serving paths, documents the encoding contract on
> RequestUtils.getServletPath(), and adds test coverage.
> PR: https://github.com/apache/struts/pull/1777
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
