[
https://issues.apache.org/jira/browse/WW-5580?focusedWorklogId=1031444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1031444
]
ASF GitHub Bot logged work on WW-5580:
--------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/26 09:16
Start Date: 21/Jul/26 09:16
Worklog Time Spent: 10m
Work Description: lukaszlenart opened a new pull request, #1798:
URL: https://github.com/apache/struts/pull/1798
Aligns FreeMarker's `incompatible_improvements` setting in
`FreemarkerManager` with the FreeMarker 2.3.34 dependency already declared in
the build (it was still pinned to `VERSION_2_3_33`).
### Risk
None at runtime. FreeMarker 2.3.34 declares `Configuration.VERSION_2_3_34`
as an incompatible-improvements break-point, but nothing in 2.3.34 gates
behaviour on it:
- `_VersionInts` defines `V_2_3_33` but no `V_2_3_34`
- the only version comparisons (`BeansWrapper`, `ClassIntrospectorBuilder`)
cap at 2.3.33
- the `setIncompatibleImprovements` javadoc change list stops at 2.3.33
So this is purely keeping the setting in sync with the dependency.
### Tests
`testIncompatibleImprovementsByOverriding` intentionally stays on
`VERSION_2_3_33` — it now asserts a value that differs from the default, so it
actually exercises the override path (previously it matched the default and
passed trivially).
All 26 tests in `org.apache.struts2.views.freemarker.**` pass, including the
template rendering/auto-escaping test.
Fixes [WW-5580](https://issues.apache.org/jira/browse/WW-5580)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Issue Time Tracking
-------------------
Worklog Id: (was: 1031444)
Remaining Estimate: 0h
Time Spent: 10m
> Use Configuration.VERSION_2_3_34 for Freemaker config
> -----------------------------------------------------
>
> Key: WW-5580
> URL: https://issues.apache.org/jira/browse/WW-5580
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Tags
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 7.3.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently Struts uses {{Version incompatibleImprovements =
> Configuration.VERSION_2_3_33;}} but it depends on Freemarker 2.3.34 - it
> would be good to use a proper version which is
> {{Configuration.VERSION_2_3_34}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
