[ 
https://issues.apache.org/jira/browse/WW-3427?focusedWorklogId=1032275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1032275
 ]

ASF GitHub Bot logged work on WW-3427:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jul/26 08:29
            Start Date: 26/Jul/26 08:29
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #1814:
URL: https://github.com/apache/struts/pull/1814#issuecomment-5082722637

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1814) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1814&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1814&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1814&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1814&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1814&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1032275)
    Time Spent: 20m  (was: 10m)

> If you alias a property that uses a custom TypeConverter and it throws 
> TypeConversionException the error is never caught
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3427
>                 URL: https://issues.apache.org/jira/browse/WW-3427
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.1.8.1
>         Environment: Windows
>            Reporter: Sloan Seaman
>            Assignee: Lukasz Lenart
>            Priority: Major
>              Labels: conversion, struts, type
>             Fix For: 7.3.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> If you define an alias to a property like so:
> {code:java}
> @Actions({
>   @Action(
>     value="/icc/saveScan",
>     interceptorRefs=@InterceptorRef("ptiDefault"),
>     results={
>       @Result(name="input", location="/error.jsp"), 
>       @Result(name="success", location="/success.jsp")
>     },
>     params={"aliases", 
>       "#{\"plateId\" : \"plate\", " +
>         "\"machineAbbr\" : \"machine\", "+
>         "\"imageFiles\" : \"scanData\"}"
>     }
>     */
>   )
> })
> {code}
> and the property (say imageFiles/scanData) has a custom TypeConverter 
> configured like so:
> {code:java}
>       @ConversionErrorFieldValidator(type = ValidatorType.FIELD, 
>               key="invalid.fieldvalue.xxx",
>               message = "well not found or imageFiles not in format: 
> file,wellId|file,wellId|...",
>               shortCircuit=true)
>       @TypeConversion(rule = ConversionRule.COLLECTION, 
>               converter = "com.ptilabs.icc.action.ScanData")
>       public void setScanData(List<ScanData> imageFiles) {
>               this.imageFiles = imageFiles;
>       }
> {code}{
> If the {{TypeConverter}} throws a {{TypeConversionException}} the exception 
> is never caught by the {{ConversionErrorInterceptor}} or 
> {{ConversionErrorFieldValidator}}.
> If I disable the aliasing and rename the method {{setImageFiles}} everything 
> works correctly.
> I'm trying to debug on my own but I can't find the class responsible for 
> catching the {{TypeConversionException}} and placing it in the 
> {{invocationContext.getConversionErrors()}}
>               



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to