[ 
https://issues.apache.org/jira/browse/WW-3226?focusedWorklogId=1041076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1041076
 ]

ASF GitHub Bot logged work on WW-3226:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Sep/26 07:49
            Start Date: 12/Sep/26 07:49
    Worklog Time Spent: 10m 
      Work Description: lukaszlenart opened a new pull request, #1918:
URL: https://github.com/apache/struts/pull/1918

   Relates to [WW-3226](https://issues.apache.org/jira/browse/WW-3226).
   
   WW-3226 asked for an `overwrite` flag on `AliasInterceptor`. Triage showed 
the behaviour is already decided by interceptor ordering: `alias` and `params` 
both set the target property when they run, so whichever runs last wins. 
[struts-site#329](https://github.com/apache/struts-site/pull/329) documents 
that; this PR pins it with two tests so the documented promise is enforced:
   
   - `alias` before `params` (the `defaultStack` order) — the directly 
submitted parameter wins.
   - `params` before `alias` — the alias overrides the submitted parameter.
   
   Both tests also assert the source property bound, so a run where `params` 
binds nothing fails instead of passing vacuously. Test-only; no production 
change. The ticket itself is being closed as Won't Fix.
   
   Security review: clean — test-only diff, no shipped code touched.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 1041076)
    Time Spent: 20m  (was: 10m)

> Add optional support to AliasInterceptor to overwrite aliased parameters
> ------------------------------------------------------------------------
>
>                 Key: WW-3226
>                 URL: https://issues.apache.org/jira/browse/WW-3226
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.1.8
>            Reporter: Jasper Rosenberg
>            Priority: Minor
>             Fix For: 7.4.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> It would be great if the AliasInterceptor could overwrite the aliased 
> parameters rather than just inject them under different names, much like I 
> recall staticParams supports.  I suspect many, like me, were surprised to 
> learn this wasn't how it currently behaved.  It would have to be a new flag 
> to maintain backwards compatibility.
> Alternatively, the ParametersInterceptor could be enhanced to take an 
> optional aliases map.  That would be pretty handy.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to