[ 
https://issues.apache.org/jira/browse/WW-3245?focusedWorklogId=1041089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1041089
 ]

ASF GitHub Bot logged work on WW-3245:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Sep/26 08:43
            Start Date: 12/Sep/26 08:43
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #1919:
URL: https://github.com/apache/struts/pull/1919#issuecomment-5644810965

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1919) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1919&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1919&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1919&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [100.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1919&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1919&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1041089)
    Time Spent: 40m  (was: 0.5h)

> Jasper plugin does not support supply of data via report parameters (for 
> example Hibernate session object)
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3245
>                 URL: https://issues.apache.org/jira/browse/WW-3245
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - JasperReports
>    Affects Versions: 2.1.6, 2.3.20, 6.1.1
>         Environment: Present in all environments, attempting usage of 
> Hibernate query HQL embedded in a JasperReport.
>            Reporter: Andrew Hodgson
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 7.4.0
>
>         Attachments: struts2JasperReportsPluginHQLPatch.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> A typical usage scenario for a Jasper report involves writing code within the 
> report document to retrieve report from a database recent Struts code 
> supports this via supply of a SQL Connection object, but I notice it's not 
> supported in 2.1.6 production release.  
> JasperReports supports many implementation languages for it's data retrieval 
> code, but in particular I have identified issue in relation to Hibernate HQL 
> queries.
> Normal route in this scenario (if not using Struts JasperReports plugin) is 
> to supply Hibernate session as a parameter to the report, then implement HQL 
> within the document to retrieve the data.  However the Plugin only supports 
> Connection or a pre-populated dataSource as a source for the report's data.  
> This means a temporary data structure (perhaps a sizable List / Map) must be 
> produced in order to present data to the Plugin..
> It would be more efficient and convenient to either support supply of a 
> Hibernate Session object, or allow call to the plugin when both connection 
> and datasource are absent.  In this scenario, the plugin would respond by 
> calling 
> http://jasperreports.sourceforge.net/api/net/sf/jasperreports/engine/JasperFillManager.html#fillReport(java.io.InputStream,%20java.util.Map)
> And rely on Jasper Fill Manager's inbuilt functionality to draw connection 
> detail from the supplied parameters. This option has the advantage that it 
> can support a range of query languages / connection methods that 
> JasperReports may support, now or in the future.  
> The code would of course have to deal with the case in which the relevant 
> report parameters have be left blank, and thus respond with an appropriate 
> error condition, as it does in Struts 2.1.6  when dataSource has been left 
> null.
> I will attempt to produce a patch with proposed modified code in the near 
> future, to assist with this improvement.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to