[ 
https://issues.apache.org/jira/browse/WW-5751?focusedWorklogId=1043587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1043587
 ]

ASF GitHub Bot logged work on WW-5751:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Sep/26 15:56
            Start Date: 23/Sep/26 15:56
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #1976:
URL: https://github.com/apache/struts/pull/1976#issuecomment-5798126040

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1976) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1976&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1976&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1976&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [93.3% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1976&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1976&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1043587)
    Time Spent: 0.5h  (was: 20m)

> null can no longer be passed as parameter to interceptor
> --------------------------------------------------------
>
>                 Key: WW-5751
>                 URL: https://issues.apache.org/jira/browse/WW-5751
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 7.3.0
>            Reporter: nikos dimitrakas
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 7.5.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Upgrading from 7.2.1 to 7.3.0 seems to have made a change so that null cannot 
> be passed as a parameter to the ActionFileUploadInterceptor.
> I have an interceptor like this:
> {code:java}
> <interceptor name="myFileUpload" 
> class="org.apache.struts2.interceptor.ActionFileUploadInterceptor">
>                 <param name="maximumSize">128000000</param>
> </interceptor>{code}
> That interceptor is then included in a global interceptor stack called 
> myFileUploadStack.
> Later in some specific actions I want to set the maximumSize to null (no 
> limit) and I do this:
> {code:java}
> <interceptor-ref name="myFileUploadStack">
>        <param name="myFileUpload.maximumSize">null</param>
> </interceptor-ref>{code}
> This used to work until 7.2.1, but in 7.3.0 it gives an error:
> The upload validation policy could not be resolved, rejecting the file: file 
> "test.pdf"; unresolved parameters: maximumSize
> Looking at the code and the release notes of 7.3.0, I can find that this 
> probably relates to the changes made in WithLazyParams.java and 
> AbstractFileUploadInterceptor.java (using a policy) as part of WW-5659. But I 
> do not see in the release notes anything about this being intended or what 
> the migration path would be. The javadoc of WithLazyParams.resolveInto() 
> mentions null and empty value becoming unresolved, but not what to do about 
> it.
> Obviously, I can set a very large number or create a second interceptor and 
> interceptorStack to get around this, but I felt that this should be reported 
> so that either it can be fixed, or it can be confirmed as the intended 
> behaviour and if so, perhaps write something about it in the release notes 
> (under Breaking changes) or in a migration guide.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to