[
https://issues.apache.org/jira/browse/WW-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-5811:
------------------------------
Description:
h2. Problem
HTML5 constraint derivation ({{struts.ui.html5.constraints}}) maps range
validators to {{min}}/{{max}} only for {{number}} and {{range}} controls.
{{HtmlControlType.supportsRange()}} already includes the temporal controls
({{date}}, {{month}}, {{week}}, {{time}}, {{datetime-local}}), but
{{StrutsHtmlConstraintProvider}} deliberately skips them, because their
{{min}}/{{max}} values need per-control ISO formatting. As a result,
{{DateRangeFieldValidator}} emits nothing.
The {{required}} validator has a related gap. {{addRequiredField}} emits
{{required}} only for {{radio}} and {{file}}, because other controls submit an
empty string, which the {{required}} validator accepts. A temporal control
bound to a {{java.util.Date}} (or {{java.time}}) property is different:
{{DateConverter}} turns {{""}} into null, so the server rejects the empty value
just as the browser would. These controls currently get only
{{data-msg-required}}.
This affects {{textfield type="date"}} (and the other temporal types) today,
and {{datetextfield}} in the html5 theme (WW-5778).
h2. Proposal
In {{StrutsHtmlConstraintProvider}}, map {{DateRangeFieldValidator}} min/max to
{{min}}/{{max}} for temporal controls, formatted per control:
* {{date}} → {{yyyy-MM-dd}}
* {{month}} → {{yyyy-MM}}
* {{week}} → {{YYYY-'W'ww}} (ISO week-based year)
* {{time}} → {{HH:mm}} (or {{HH:mm:ss}})
* {{datetime-local}} → {{yyyy-MM-dd'T'HH:mm}}
Emit {{required}} from a {{required}} validator on a temporal control only when
the bound property's type converts an empty string to null. A {{textfield
type="date"}} bound to a {{String}} property must not get it, because the
server accepts {{""}} there. The provider currently sees only the control type
and the value, so it needs the property type as well.
Requirements:
* Format the bounds the same way the server compares them, so the browser never
rejects a value the server accepts (time zone and truncation for
{{java.util.Date}} bounds)
* Skip the attribute for controls/value types that cannot be represented
exactly, as the numeric path does for fractional {{min}}
* Tests for each temporal control, including {{datetextfield}} (replace
{{Html5ConstraintRenderingTest.testRendersNoRequiredOnADateTextField}}), and
the tag reference updated
Related: WW-5778 (datetextfield in the html5 theme), WW-5810 (java.time support
in datetextfield)
was:
h2. Problem
HTML5 constraint derivation ({{struts.ui.html5.constraints}}) maps range
validators to {{min}}/{{max}} only for {{number}} and {{range}} controls.
{{HtmlControlType.supportsRange()}} already includes the temporal controls
({{date}}, {{month}}, {{week}}, {{time}}, {{datetime-local}}), but
{{StrutsHtmlConstraintProvider}} deliberately skips them, because their
{{min}}/{{max}} values need per-control ISO formatting. As a result,
{{DateRangeFieldValidator}} emits nothing.
This affects {{textfield type="date"}} (and the other temporal types) today,
and {{datetextfield}} once WW-5778 makes it a {{date}} control in the html5
theme.
h2. Proposal
In {{StrutsHtmlConstraintProvider}}, map {{DateRangeFieldValidator}} min/max to
{{min}}/{{max}} for temporal controls, formatted per control:
* {{date}} → {{yyyy-MM-dd}}
* {{month}} → {{yyyy-MM}}
* {{week}} → {{YYYY-'W'ww}} (ISO week-based year)
* {{time}} → {{HH:mm}} (or {{HH:mm:ss}})
* {{datetime-local}} → {{yyyy-MM-dd'T'HH:mm}}
Requirements:
* Format the bounds the same way the server compares them, so the browser never
rejects a value the server accepts (time zone and truncation for
{{java.util.Date}} bounds)
* Skip the attribute for controls/value types that cannot be represented
exactly, as the numeric path does for fractional {{min}}
* Tests for each temporal control and the tag reference updated
Related: WW-5778 (datetextfield in the html5 theme), WW-5810 (java.time support
in datetextfield)
> Derive HTML5 min/max constraints for temporal controls from
> DateRangeFieldValidator
> -----------------------------------------------------------------------------------
>
> Key: WW-5811
> URL: https://issues.apache.org/jira/browse/WW-5811
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Tags
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 7.5.0
>
>
> h2. Problem
> HTML5 constraint derivation ({{struts.ui.html5.constraints}}) maps range
> validators to {{min}}/{{max}} only for {{number}} and {{range}} controls.
> {{HtmlControlType.supportsRange()}} already includes the temporal controls
> ({{date}}, {{month}}, {{week}}, {{time}}, {{datetime-local}}), but
> {{StrutsHtmlConstraintProvider}} deliberately skips them, because their
> {{min}}/{{max}} values need per-control ISO formatting. As a result,
> {{DateRangeFieldValidator}} emits nothing.
> The {{required}} validator has a related gap. {{addRequiredField}} emits
> {{required}} only for {{radio}} and {{file}}, because other controls submit
> an empty string, which the {{required}} validator accepts. A temporal control
> bound to a {{java.util.Date}} (or {{java.time}}) property is different:
> {{DateConverter}} turns {{""}} into null, so the server rejects the empty
> value just as the browser would. These controls currently get only
> {{data-msg-required}}.
> This affects {{textfield type="date"}} (and the other temporal types) today,
> and {{datetextfield}} in the html5 theme (WW-5778).
> h2. Proposal
> In {{StrutsHtmlConstraintProvider}}, map {{DateRangeFieldValidator}} min/max
> to {{min}}/{{max}} for temporal controls, formatted per control:
> * {{date}} → {{yyyy-MM-dd}}
> * {{month}} → {{yyyy-MM}}
> * {{week}} → {{YYYY-'W'ww}} (ISO week-based year)
> * {{time}} → {{HH:mm}} (or {{HH:mm:ss}})
> * {{datetime-local}} → {{yyyy-MM-dd'T'HH:mm}}
> Emit {{required}} from a {{required}} validator on a temporal control only
> when the bound property's type converts an empty string to null. A
> {{textfield type="date"}} bound to a {{String}} property must not get it,
> because the server accepts {{""}} there. The provider currently sees only the
> control type and the value, so it needs the property type as well.
> Requirements:
> * Format the bounds the same way the server compares them, so the browser
> never rejects a value the server accepts (time zone and truncation for
> {{java.util.Date}} bounds)
> * Skip the attribute for controls/value types that cannot be represented
> exactly, as the numeric path does for fractional {{min}}
> * Tests for each temporal control, including {{datetextfield}} (replace
> {{Html5ConstraintRenderingTest.testRendersNoRequiredOnADateTextField}}), and
> the tag reference updated
> Related: WW-5778 (datetextfield in the html5 theme), WW-5810 (java.time
> support in datetextfield)
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
