[
https://issues.apache.org/jira/browse/WW-5824?focusedWorklogId=1051588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1051588
]
ASF GitHub Bot logged work on WW-5824:
--------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/26 09:20
Start Date: 31/Oct/26 09:20
Worklog Time Spent: 10m
Work Description: sonarqubecloud[bot] commented on PR #2079:
URL: https://github.com/apache/struts/pull/2079#issuecomment-6541627052
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=2079)
**Quality Gate passed**
Issues
 [0 New
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2079&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2079&issueStatuses=ACCEPTED)
Measures
 [0 Security
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=2079&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2079&metric=new_coverage&view=list)
 [0.0% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2079&metric=new_duplicated_lines_density&view=list)
<!
Issue Time Tracking
-------------------
Worklog Id: (was: 1051588)
Time Spent: 20m (was: 10m)
> Radio tag renders its name attribute without HTML escaping, unlike every
> other form tag
> ---------------------------------------------------------------------------------------
>
> Key: WW-5824
> URL: https://issues.apache.org/jira/browse/WW-5824
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 7.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The radio template is the only bundled form template that writes the {{name}}
> attribute with {{?no_esc}}. Every sibling template (checkbox, checkboxlist,
> text, select, file, hidden, password, textarea, submit, reset, form) writes
> it under the FreeMarker auto-escaping configured for the UI templates, and
> the javatemplates plugin escapes it as well.
> The exception dates from the original template, which never carried the
> per-parameter {{?html}} the checkbox template had. When the templates moved
> to built-in auto-escaping in WW-4972, the radio template kept its previous
> output by adding {{?no_esc}} to that one attribute.
> h2. Current behaviour
> A radio with a name containing a double quote, rendered under the {{simple}},
> {{xhtml}} or {{html5}} theme, closes the attribute early:
> {code}<input type="radio" name="x" onfocus="alert(1)"
> id="x__onfocus__alert_1_a" value="a"/>
> {code}
> A checkboxlist with the same name renders the quote as {{"}}.
> h2. Expected behaviour
> The radio name is written the same way as on every other tag, HTML-escaped.
> h2. Change
> Remove {{?no_esc}} from the {{name}} attribute in the {{simple}} and
> {{html5}} radio templates and pin the escaped output with a test. One
> existing fixture, Radio-6.txt, pins a name containing apostrophes;
> auto-escaping renders those as {{'}}, as the combobox fixtures already
> show.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
