[ 
https://issues.apache.org/jira/browse/SVN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Zhakov updated SVN-4248:
-----------------------------
    Fix Version/s:     (was: 1.8-consider)
                   1.8.0

> Remove NLS check for KWallet support and reorder private includes
> -----------------------------------------------------------------
>
>                 Key: SVN-4248
>                 URL: https://issues.apache.org/jira/browse/SVN-4248
>             Project: Subversion
>          Issue Type: Improvement
>          Components: libsvn_auth_kwallet
>    Affects Versions: ---
>            Reporter: Subversion Importer
>              Labels: patch
>             Fix For: 1.8.0
>
>         Attachments: 1_do-not-require-nls-for-kwallet-support-v2.diff
>
>
> {noformat:nopanel=true}
> Following Daniel's suggestions in previous thread, attached is another 
> iteration 
> of the patch that removes the need for NLS to be enabled for KWallet support 
> to 
> be built.
> Besides removing the NLS check from kwallet.m4 as the previous patch did, 
> this 
> one also reorders the includes in kwallet.cpp so that the private Subversion 
> includes come after the system/KDE ones. The same has been done to the GNOME 
> Keyring code, as well as another file.
> In most of the cases, svn_private_config.h is already one of the last files 
> to 
> be included, and I felt it was too dangerous to change the cases where it was 
> included before some feature checks or apr includes.
> {noformat}
> http://svn.haxx.se/dev/archive-2012-09/0215.shtml
> Original issue reported by *gavinbaumanis*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to