[ 
https://issues.apache.org/jira/browse/SVN-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155989#comment-15155989
 ] 

Oleksiy Zagorskyi commented on SVN-4622:
----------------------------------------

Hi!
I'm the person who originally faced with this issue.
Thanks Philip to confirming it and creating this bug report.

Now I did additional test and can confirm that it's related to write 
permissions, not to owners difference I supposed originally.
I.e. if "svn revert" issuer doesn't have *write* permissions to a file - the 
file is always reported as "Reverted".
It's actual for root and *regular* user too! -> Issue summary should be 
adjusted.
{code}
$ whoami
zalex

$ ls -l zbxdbupgrade.h
-rw-rw-r-- 1 root root 863 Feb 21 12:20 zbxdbupgrade.h

$ svn -R revert zbxdbupgrade.h
Reverted 'zbxdbupgrade.h'

$ svn -R revert zbxdbupgrade.h
Reverted 'zbxdbupgrade.h'
...
{code}
If the user has *write* permissions (by group membership or by "others") to the 
file - then the issue is not reproducible.

There, in the email channel, was an assumption from Bert Huijben:
{quote}
Does the file have any specific 'svn:' properties set on it?
I'm guessing that it has a 'svn:eol-style' set on it.
The only known reproducible case of this issue involves getting a non-standard 
encoded EOL in your repository, with an eol-style defined that should convert 
it to another style.
{quote}
I can confirm that it's not related to any 'svn:' property, as files I tested, 
do not have any  'svn:' property set.

> revert as root always notifies for files
> ----------------------------------------
>
>                 Key: SVN-4622
>                 URL: https://issues.apache.org/jira/browse/SVN-4622
>             Project: Subversion
>          Issue Type: Bug
>          Components: libsvn_subr
>    Affects Versions: all
>            Reporter: Philip Martin
>            Priority: Minor
>
> $ svnadmin create repo
> $ svn import -mm repo/format file://`pwd`/repo/f
> $ umask 0022
> $ svn co file://`pwd`/repo wc
> $ sudo svn revert wc/f
> Reverted 'wc/f'
> The function svn_io__is_finfo_read_only() will check the world permissions 
> when invoked with uid=root. A typical umask removes world write so this means 
> that root sees every file as read-only. This causes the revert code to invoke 
> svn_io_set_file_read_write() and notify. However svn_io_set_file_read_write() 
> sets the owner permissions, an operation that succeeds when run as root, and 
> obeys the umask so the world permissions remain read-only.
> Reported by:
> https://mail-archives.apache.org/mod_mbox/subversion-users/201602.mbox/%3C56C0738E.9010508%40i.ua%3E
> http://svn.haxx.se/users/archive-2016-02/0061.shtml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to