[ 
https://issues.apache.org/jira/browse/SVN-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405572#comment-16405572
 ] 

Melissa Mears commented on SVN-4722:
------------------------------------

Hi.  I was the original reporter of this.  I've confirmed that the 1826272 
commit gets past the two errors we were having.

The problem occurred twice in a project with 615,000 revisions and 20 years of 
code history (Visual SourceSafe -> CVS -> Subversion in 2005).  Only one of 
these occurred during 1.9.x's lifetime, leading to finding the bug.  The other 
occurred when retroactively processing old revisions in 1.9.x via "svnsync".  I 
guess that's one anecdote for measuring the rarity of the bug.

Thanks for fixing this!

> checksum fail during commit when delta is 16K
> ---------------------------------------------
>
>                 Key: SVN-4722
>                 URL: https://issues.apache.org/jira/browse/SVN-4722
>             Project: Subversion
>          Issue Type: Bug
>          Components: libsvn_fs_fs
>    Affects Versions: 1.9.7
>            Reporter: Philip Martin
>            Priority: Major
>
> As discussed
> _Email to dev@, from Philip Martin, 2018-03-03, "Re: SHA-1 collision in 
> repository?", archived at 
> [mail-archives.apache.org|https://mail-archives.apache.org/mod_mbox/subversion-dev/201803.mbox/%3C87lgf3fda2.fsf%40codematters.co.uk%3E],
>  [svn.haxx.se|https://svn.haxx.se/dev/archive-2018-03/0070.shtml]_
> There is an error in the checksum code added to 1.9.7 to detect SHA1 
> collisions. The expanded length is calculated incorrectly and when the delta 
> length is a multiple of 16K the checksum calculation stops early and fails.
> Symptom: Commits fail with a false "Filesystem is corrupt" error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to