[
https://issues.apache.org/jira/browse/SVN-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552060#comment-16552060
]
Daniel Shahaf (äñ§€¥£¢) commented on SVN-4765:
----------------------------------------------
False positive. The SVN_DAV_* macros expand to different values, so the
conditions are different. It seems your tool does not understand string
pasting that involves expanding a preprocessor macro.
Thanks for the report!
> subversion-1.10.2/subversion/mod_dav_svn/reports/list.c:273: bad if ?
> ---------------------------------------------------------------------
>
> Key: SVN-4765
> URL: https://issues.apache.org/jira/browse/SVN-4765
> Project: Subversion
> Issue Type: Bug
> Reporter: David Binderman
> Priority: Minor
>
> [subversion-1.10.2/subversion/mod_dav_svn/reports/list.c:273]: (style)
> Expression is always false because 'else if' condition matches previous
> condition at line 271.
>
> Source code is
> else if (strcmp(name, "DAV:" SVN_DAV__VERSION_NAME) == 0)
> lrb.dirent_fields |= SVN_DIRENT_CREATED_REV;
> else if (strcmp(name, "DAV:" SVN_DAV__CREATIONDATE) == 0)
> lrb.dirent_fields |= SVN_DIRENT_TIME;
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
