[
https://issues.apache.org/jira/browse/SVN-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498284#comment-17498284
]
Daniel Shahaf commented on SVN-4884:
------------------------------------
Looks good. I think this is not a blocker any more, since the svn_wc_info_t
members have been removed.
Further review:
Should the new --show-item's (wc-format and wc-compatible-version) be added to
{{svn info}}'s rfc822-esque and XML output modes as well? That would allow
people to use their existing parsers and to query this value in conjunction
with all other values. Emitting format numbers there is precedented in
{{svnadmin info}}. Also, we don't have any --show-item value that's not output
by default (but perhaps it's time to add one).
svn_client__wc_version_from_format() was named with double underscores but
placed in a public header file. It should either be moved to a private header
file or renamed with single underscores — probably the latter, since
third-party clients should be able to mimic the command-line's functionality.
> multi-wc-format: user visibility of WC version
> ----------------------------------------------
>
> Key: SVN-4884
> URL: https://issues.apache.org/jira/browse/SVN-4884
> Project: Subversion
> Issue Type: Bug
> Reporter: Daniel Shahaf
> Priority: Major
> Labels: api
> Fix For: 1.15.0
>
>
> Daniel Shahaf wrote, in dev@ email "multi-wc-format review":
> 1. How can a user ask a working copy what range of minor versions it
> supports? Cf. "Compatible With Version:" in `svnadmin info` output.
> I see these:
> % subversion/svn/svn info wc --show-item=wc-format
> 31
> % subversion/svn/svn info wc --show-item=wc-format-min
> 31
> % subversion/svn/svn info wc --show-item=wc-format-max
> 32
> %
> but:
> - They emit format numbers rather than version numbers. It would be
> more useful to emit version numbers, or at least to expose the
> format-number-to-version-number mapping in the public API.
> - They aren't documented in the release notes (only in the help output).
> - wc-format-min and wc-format-max are not attributes of the working
> copy but of the Subversion library doing the query. It's this way
> even in the API (svn_wc_info_t::wc_format_min and
> svn_wc_info_t::wc_format_max), but shouldn't we change this? "Do one
> thing and do it well.". «svn info»'s one thing is to report properties
> of the working copy. Information about the library's capabilities
> clearly belongs in «svn --version --xml» ;-)
> [«svn --version» does in fact print the library's supported version
> number range already.]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
