[
https://issues.apache.org/jira/browse/SVN-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518269#comment-17518269
]
Julian Foad edited comment on SVN-4891 at 4/6/22 4:10 PM:
----------------------------------------------------------
{code:none}
trans_tests.py 1 keywords_from_birth(): commit new files with keywords
active from birth
{code}
It fails on one check within the whole test case, where it tries to read the
text-base directly, to check the unexpanded forms of fixed-length keywords. We
could:
- bypass that check, or
- modify that check to read the "apparent" text base by equivalent of a local
"svn cat" (which in pristines-on-demand is implemented by detranslating from
the working file), or
- modify that check to read from the repository (non-local "svn cat"
equivalent).
The last option would be best I think. Trying that... it fails due to mismatch
of expected keywords in the text-base after a commit:
{code:none}
W: text base item 3, Expected: $URL:: $
W: text base item 3, Got: $URL:: f#$
{code}
For now, I am committing that much, also changing the test function's decorator
so it will report XFAIL in pristines-on-demand mode and PASS otherwise.
Committed r1899622.
was (Author: julianfoad):
{code:none}
trans_tests.py 1 keywords_from_birth(): commit new files with keywords
active from birth
{code}
It fails on one check within the whole test case, where it tries to read the
text-base directly, to check the unexpanded forms of fixed-length keywords. We
could:
- bypass that check, or
- modify that check to read the "apparent" text base by equivalent of a local
"svn cat" (which in pristines-on-demand is implemented by detranslating from
the working file), or
- modify that check to read from the repository (non-local "svn cat"
equivalent).
The last option would be best I think. Trying that... it fails due to mismatch
of expected keywords:
{code:none}
W: text base item 3, Expected: $URL:: $
W: text base item 3, Got: $URL:: f#$
{code}
For now, I am committing that much, also changing the test function's decorator
so it will report XFAIL in pristines-on-demand mode and PASS otherwise.
Committed r1899622.
> Pristines-on-demand: fix disabled tests
> ---------------------------------------
>
> Key: SVN-4891
> URL: https://issues.apache.org/jira/browse/SVN-4891
> Project: Subversion
> Issue Type: Bug
> Reporter: Julian Foad
> Assignee: Julian Foad
> Priority: Major
>
> The following tests had been changed in the pristines-on-demand development.
> Most were disabled with the '@Wimp' decorator. (This caused some of them to
> give an XPASS and some an XFAIL result when run against the older WC format,
> and all XFAIL against the newer WC format.)
> They need to be re-enabled and fixed.
> (I am removing them from this list as and when fixed.)
> {code:java}
> basic_tests.py 8 basic_commit_corruption(): basic corruption detection on
> commit
> [[Relies on wc.text_base_path()]]
> basic_tests.py 9 basic_update_corruption(): basic corruption detection on
> update
> [[Relies on wc.text_base_path()]]
> externals_tests.py ... ... ...:
> update_modify_file_external(),
> remap_file_external_with_prop_del(),
> file_external_recorded_info():
> existing issue (Windows only)
> revert_tests.py 2 revert_reexpand_keyword(): revert reexpands manually
> contracted keyword
> "See r1101730 and r1101817"
> trans_tests.py 1 keywords_from_birth(): commit new files with keywords
> active from birth
> [[Relies on wc.text_base_path()]]
> trans_tests.py 3 eol_change_is_text_mod(): committing eol-style change
> forces text send
> [[Relies on wc.text_base_path()]]
> update_tests.py 57 skip_access_denied(): access denied paths should be
> skipped
> - on Unix: SKIP.
> - on Windows: XFAIL/WIMP in pristines-on-demand mode, XPASS on old WC
> format.
> upgrade_tests.py 16 replaced_files(): upgrade with base and working
> replaced files
> - XFAIL in pristines-on-demand mode; PASS with the old WC format.
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
