[ 
https://issues.apache.org/jira/browse/SYSTEMML-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233120#comment-15233120
 ] 

Deron Eriksson commented on SYSTEMML-620:
-----------------------------------------

ParseException contains old javacc Token references, which should be removed 
(SYSTEMML-502).

There already exists a DMLParseException class that is a subclass if 
ParseException. These should basically be merged into a single class 
(DMLParseException) that subclasses DMLException. This will help with the 
cleanup of the exception handling in the project (SYSTEMML-616).

> Rename ParseException and/or subclass DMLException
> --------------------------------------------------
>
>                 Key: SYSTEMML-620
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-620
>             Project: SystemML
>          Issue Type: Task
>          Components: Parser
>            Reporter: Deron Eriksson
>
> Noted by [~freiss] WRT SYSTEMML-611:
> "If you're going to expose ParseException here, consider either renaming it 
> to DMLParseException or making it a subclass of DMLException. Other systems 
> and libraries use the name "ParseException", and we don't want users to have 
> to type enter fully-qualified class names because they ended up with code 
> that throws two kinds of "ParseException"."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to